Comments on: Classes for file uploading in PHP http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/ Polluting the internet since 2004 Fri, 26 Feb 2010 16:32:30 +0000 http://wordpress.org/?v=2.9.1 hourly 1 By: Tom http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-914 Tom Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-914 Mmmmm. Mmmmm.

]]> By: Bryce http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-915 Bryce Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-915 Hey,</p> <p></p> <p>This code in conjunction with stickmans script were just what I was looking for in my administrator upload system. I do have one question that I was wondering if you could help me with. I created a little mockup using yours and stickmans code, and have been having trouble with the number of files uploaded. Specifically, if for example the max number of files is set to 5 and I upload 5 files, the system works fine, however if I try to upload less then 5 files, it doesn't work at all. I was just wondering if you might know why its doing this. My code is included below:</p> <p><pre><html> <head> <!-- Include the javascript --> <script src="multifile_compressed.js"></script> </head> <body> <!-- This is the form --> <form enctype="multipart/form-data" action="uploadtest.php?action=upload" method = "post"> <!-- The file element -- NOTE: it has an ID --> <input id="my_file_element" type="file" name="file_1" > <input type="submit"> </form> Files: <!-- This is where the output will appear --> <div id="files_list"></div> <script> <!-- Create an instance of the multiSelector class, pass it the output target and the max number of files --> var multi_selector = new MultiSelector( document.getElementById( 'files_list' ), 3 ); <!-- Pass in the file element --> multi_selector.addElement( document.getElementById( 'my_file_element' ) ); </script> </body> </html> <?php /** * This represents just the file portion of the form processing */ require_once('Upload.class.php'); require_once('MimeTypes.class.php'); if(isset($_GET['action'])) {    $action = $_GET['action'];    if($action == 'upload') {       upload();    } } function upload() {    // set destination folder    $destination = 'upload/';    $m = new AP_File_MimeTypes();    $types = $m->getTypes('image');    unset($m);    // start new upload object    $ul = new AP_File_Upload($types);    echo "hello";    // loop through uploaded files and save each one    foreach($_FILES as $file)    {       if($ul->save_file($file,$destination) == false)       {          // you'll want to handle error in some way          // more elegant than dying          die($ul->get_error());        }    }     // continue processing files as needed } ?> </pre></p> <p></p> <p></p> <p>Thanks for the code, and help Hey,

This code in conjunction with stickmans script were just what I was looking for in my administrator upload system. I do have one question that I was wondering if you could help me with. I created a little mockup using yours and stickmans code, and have been having trouble with the number of files uploaded. Specifically, if for example the max number of files is set to 5 and I upload 5 files, the system works fine, however if I try to upload less then 5 files, it doesn’t work at all. I was just wondering if you might know why its doing this. My code is included below:

<html>

<head>
    <!-- Include the javascript -->
    <script src="multifile_compressed.js"></script>
</head>

<body>

<!-- This is the form -->
<form enctype="multipart/form-data" action="uploadtest.php?action=upload" method = "post">
    <!-- The file element -- NOTE: it has an ID -->
    <input id="my_file_element" type="file" name="file_1" >
    <input type="submit">
</form>
Files:
<!-- This is where the output will appear -->
<div id="files_list"></div>
<script>
    <!-- Create an instance of the multiSelector class, pass it the output target and the max number of files -->
    var multi_selector = new MultiSelector( document.getElementById( 'files_list' ), 3 );
    <!-- Pass in the file element -->
    multi_selector.addElement( document.getElementById( 'my_file_element' ) );
</script>
</body>
</html>

<?php
/**
* This represents just the file portion of the form processing
*/
require_once('Upload.class.php');
require_once('MimeTypes.class.php');

if(isset($_GET['action'])) {
   $action = $_GET['action'];

   if($action == 'upload') {
      upload();
   }
}

function upload()
{
   // set destination folder
   $destination = 'upload/';

   $m = new AP_File_MimeTypes();
   $types = $m->getTypes('image');
   unset($m);

   // start new upload object
   $ul = new AP_File_Upload($types);

   echo "hello";

   // loop through uploaded files and save each one
   foreach($_FILES as $file)
   {
      if($ul->save_file($file,$destination) == false)
      {
         // you'll want to handle error in some way
         // more elegant than dying
         die($ul->get_error());
       }
   }

    // continue processing files as needed
}

?>

Thanks for the code, and help

]]> By: Roni http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-916 Roni Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-916 First of all, a huge thank you for both you and stickman for this code. That is great of you both to provide your code for all of us. Unfortunately, I'm having the same problem as Bryce. If I upload the number of files that my max is set to, I have no problems. But if I upload any less than the max, none of the files upload. Any thoughts? Any help you can provide is much appreciated. First of all, a huge thank you for both you and stickman for this code. That is great of you both to provide your code for all of us. Unfortunately, I’m having the same problem as Bryce. If I upload the number of files that my max is set to, I have no problems. But if I upload any less than the max, none of the files upload. Any thoughts? Any help you can provide is much appreciated.

]]> By: Shawn Parker http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-917 Shawn Parker Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-917 I finally got a minute to look at this and the error has been fixed above. I had forgotten a little quirk in the results of the script where if the limit wasn't reached then there would be an empty item in the $_FILES array.</p> <p>Unfortunately, Roni & Bryce, you guys didn't leave your email address so hopefully you check back to find this soon. I finally got a minute to look at this and the error has been fixed above. I had forgotten a little quirk in the results of the script where if the limit wasn’t reached then there would be an empty item in the $_FILES array.

Unfortunately, Roni & Bryce, you guys didn’t leave your email address so hopefully you check back to find this soon.

]]> By: André http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-918 André Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-918 Ijust tryed these scripts and classes ant i have the same error as decribed above. My max is three files and i select only one or two, i get the message "No file uploaded. Please select a file to upload".</p> <p>I did not find where the test was done.</p> <p>Thanks for the code, thanks for help ? Ijust tryed these scripts and classes ant i have the same error as decribed above. My max is three files and i select only one or two, i get the message "No file uploaded. Please select a file to upload".

I did not find where the test was done.

Thanks for the code, thanks for help ?

]]> By: Shawn Parker http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-919 Shawn Parker Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-919 Just confirm, you tried it with the revised code from the post and not with the code from Bryce?</p> <p></p> <p>Bryce's code will work by changing one line. Change line 61 from:</p> <p><pre>if($ul->save_file($file,$destination) == false)</pre></p> <p>to</p> <p><pre>if(!empty($file['name']) && $ul->save_file($file,$destination) == false)</pre> Just confirm, you tried it with the revised code from the post and not with the code from Bryce?

Bryce’s code will work by changing one line. Change line 61 from:

if($ul->save_file($file,$destination) == false)

to

if(!empty($file['name']) && $ul->save_file($file,$destination) == false)

]]> By: mobilfunk http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-920 mobilfunk Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-920 Wow, this script in connection with a multiple file-upload-script is very useful. thanks for that! Wow, this script in connection with a multiple file-upload-script is very useful. thanks for that!

]]> By: boggins http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-921 boggins Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-921 coluld you please provide a php4 solution. I tried removing the public/private stuff, managed to get it to not produce any errors but it does not actually upload any files :-( Worked fine on php5, but my client has php4. I can't get the original script you posted on the stickman forum to work on 4 either. coluld you please provide a php4 solution. I tried removing the public/private stuff, managed to get it to not produce any errors but it does not actually upload any files :-( Worked fine on php5, but my client has php4. I can’t get the original script you posted on the stickman forum to work on 4 either.

]]> By: Shawn Parker http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-922 Shawn Parker Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-922 Boggins, </p> <p>Sorry, but its not likely. I haven't worked on php4 in quite a while and I'm pretty bogged down (to use the obvious pun). </p> <p></p> <p>I'll see if I can make time for it though.</p> <p></p> <p>As for the original script, not sure why it wouldn't work, that's code directly from a page I have in production now. Boggins,

Sorry, but its not likely. I haven’t worked on php4 in quite a while and I’m pretty bogged down (to use the obvious pun).

I’ll see if I can make time for it though.

As for the original script, not sure why it wouldn’t work, that’s code directly from a page I have in production now.

]]> By: boggins http://top-frog.com/2006/12/22/classes_for_file_uploading_in_php/comment-page-1/#comment-923 boggins Wed, 31 Dec 1969 17:00:00 +0000 http://top-frog.com/?p=205#comment-923 Shawn, thanks for the reply. Now sorted, nothing wrong with your script ;-) Shawn, thanks for the reply. Now sorted, nothing wrong with your script ;-)

]]>